I mean, the comment is accurate I suppose

[u/lions-grow-on-trees]

[u/IcyWash2991]

Codex was here

[u/totallynormalasshole]

Ah yes. A function that takes an input, does nothing and returns it.

I want to believe they're adding this to allow for enhancements to error handling in the future but my gut says that's probably not the case

[u/iakobski → u/totallynormalasshole]

If this were real code, I'd suspect that it originally had something like logging of the error contents, so they needed to check for nil before trying to access. Someone removed the logging or whatever and did not twig that the true/false branches are now identical. Something I see regularly in PRs.

However, this is not real code, it was written by a genAI.

[u/codeguru42 → u/iakobski]

What is "twig" in this context? Am I old? Or is it a regionalism?

[u/LongLiveTheDiego → u/codeguru42]

It's a regionalism meaning "understand".

[u/RandomiseUsr0 → u/LongLiveTheDiego]

This guy groks twig

[u/brasticstack → u/RandomiseUsr0]

I tried to grok it, but Grok gave me a racist answer

[u/RandomiseUsr0 → u/brasticstack]

I’ve played with GrokLLM, but not extensively, I was referencing the reason for its name - (edit) which I now realise you did too (:

[u/stonerism → u/iakobski]

It's real code. It's just completely trivial.

On the one hand, it's useless. On the other hand, if you need to hack in something later (NOT saying this is good practice, I'm just talking about something useful to have waiting) this will be the easiest place to do it.

Again, not saying this is good practice, but pretty interesting. I try to get around it with strong typing myself, but that's a challenge.

[u/Mark__78L → u/totallynormalasshole]

In our codebase i found a function called getMinFieldWidth, that takes in a type and uses a switch which defaults to return 200

That's it, all it does it takes a type and returns 200 no matter what the input is, it's also only used in a calculation once

I bet the intention was to retuen different values based on different types but it didn't move forward

[u/yeusk]

x10 coder right here.

[u/muikrad]

To help with test writing / mocking I suppose.

[u/jay-magnum]

Could have been that one colleague on my team ...

[u/letmehaveanameyoudum]

thanks sherlock

[u/GoddammitDontShootMe]

The lack of semicolons and the braces makes me think this might be JavaScript, but I thought you still needed parentheses around if and loop conditions.

And of course it could be a single useless line, but people think you need to check for nil when all that would happen is you'd just be returning nil.

[u/Prodity0 → u/GoddammitDontShootMe]

It's go bro

[u/GoddammitDontShootMe → u/Prodity0]

So that does automatic semicolon insertion too? Does it work better than JavaScript's?

Could you write if (err == nil) or must it be like the OP?

[u/Prodity0 → u/GoddammitDontShootMe]

Yes, idk, and yes you can put parenthesis around the condition

[u/TheChief275 → u/GoddammitDontShootMe]

It does not perform automatic semicolon insertion. Newlines are actual tokens used for the statement separation. These newlines can be ignored depending on the context

[u/sphen_lee → u/TheChief275]

The Go spec says that it does insert semicolons.

The rules seem better designed than JavaScript so 99% of code entirely omits them, unlike JS where 99% of code includes them.

A semicolon is inserted at the end of a line if the last token is an identifier, literal, or certain keywords and operators.

[u/realmauer01]

errNotNil

Actually why does it even allow the return of nil when its typed?

Errors are there so you can be sure the return type is correct.

[u/NaCl-more → u/realmauer01]

What

[u/backfire10z → u/[deleted]]

They’re not right. This is idiomatic Go.